[cmake] Ask for PROCESSOR_DESCRIPTION if cmake version is 3.10 or later.#6605
Merged
Conversation
|
Starting build on |
oshadura
approved these changes
Oct 12, 2020
oshadura
left a comment
oshadura
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! We will need at the same moment probably increase the minimal version of CMake.
davidrohr
reviewed
May 17, 2021
| cmake_host_system_information(RESULT PROCESSOR QUERY PROCESSOR_DESCRIPTION) | ||
| if (${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.10.0") | ||
| if (${CMAKE_MINIMUM_REQUIRED_VERSION} VERSION_GREATER_EQUAL "3.10.0") | ||
| message(FATAL_ERROR "Remove this condition") |
There was a problem hiding this comment.
This breaks the compilation for me, when a dependency is pulled in, which sets a higher minimum required cmake version. Why is this check and the fatal error needed? Wouldn't it be sufficient to just check if (${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.10.0")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.